Open dependabot[bot] opened 4 years ago
rayellis4
commented
4 years ago There's a problem with this update: the embedded sagecell code (see ShowGAPCode.js, currently used by the GroupInfo page) contains its own copy of jQuery, 3.3.1, which it uses to redefine the global symbol $ when it is loaded. Although I can imagine workarounds (Use two versions of jQuery at once? Make our own modified copy of embedded_sagecell, and maintain it?), I don't see any great benefit. Let's put it on hold.
nathancarter
commented
4 years ago Since GAP in SageCell has problems at present (not letting us send more than a certain number of characters, or it simply fails) the best solution later might be to create our own copy of embdded_sagecell.js. There was a time when I investigate how to fix the problem and came up with a solution that the SageCell folks didn't like and didn't want to use, but it's been long enough now that I forget what it was. Googling just now couldn't seem to find the relevant online discussion, or I'd cite it!
Bumps jquery from 3.4.1 to 3.5.0.
Commits
7a0a8503.5.08570a08Release: Update AUTHORS.txtda3dd85Ajax: Do not execute scripts for unsuccessful HTTP responses065143cAjax: Overwrite s.contentType with content-type header value, if any1a4f10dTests: Blacklist one focusin test in IE9e15d6bEvent: Use only one focusin/out handler per matching window & document966a709Manipulation: Skip the select wrapper for <option> outside of IE 91d61fd9Manipulation: Make jQuery.htmlPrefilter an identity function04bf577Selector: Update Sizzle from 2.3.4 to 2.3.57506c9cBuild: Resolve Travis config warningsMaintainer changes
This version was pushed to npm by mgol, a new releaser for jquery since your current version.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/nathancarter/group-explorer/network/alerts).