Open etiennebacher opened 1 year ago
Base: 93.59% // Head: 93.60% // Increases project coverage by +0.01%
:tada:
Coverage data is based on head (
e6e28e8
) compared to base (3cc0a99
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
TODO: the following code doesn't produce the right output (note that the output is also wrong without this PR):
suppressPackageStartupMessages(library(poorman))
d <- data.frame(
orig = rep(c("France", "UK"), each = 4),
dest = rep(c("Spain", "Germany"), times = 4),
year = rep(rep(c(2010, 2011), each = 2), 2),
value = 1:8
)
d[2, 1] <- NA
d[7, 2] <- NA
d
#> orig dest year value
#> 1 France Spain 2010 1
#> 2 <NA> Germany 2010 2
#> 3 France Spain 2011 3
#> 4 France Germany 2011 4
#> 5 UK Spain 2010 5
#> 6 UK Germany 2010 6
#> 7 UK <NA> 2011 7
#> 8 UK Germany 2011 8
d %>%
group_by(orig, dest) %>%
group_data()
#> orig dest .rows
#> 1 France Germany 4
#> 2 France Spain 1, 3
#> 3 UK Germany 6, 8
#> 4 UK Spain 5
#> 5 UK <NA>
#> 6 <NA> Germany 2, 7
The groups UK-NA and NA-Germany should have 1 row each.
I've been away. I had every intention of reviewing this this evening but I spent it catching up on other things. I'll try and look tomorrow after work.
Related to #119.
Benchmark setup:
Before:
After: