nathanfarlow / PineappleCAS

A generic computer algebra system targeted for the TI-84+ CE calculators
MIT License
176 stars 8 forks source link

Simplify does not factor polynomials #35

Open hypersonicstorm opened 1 year ago

hypersonicstorm commented 1 year ago

Simplify doesn't seem to be working properly T-T

For example x^2+2x+1 gives x^2+2x+1 instead of (x+1)^2, and 5x+25 gives me 5x+25 instead of 5(x+5).

Expand works fine though, (x+1)^2 turns into x^2+2x+1 and 5(x+5) turns into 5x+25.

Am I doing something wrong? Any help would be appreciated.

adriweb commented 1 year ago

Well you're describing factoring but mentioning simplifying?

hypersonicstorm commented 1 year ago

idk theres no factoring function in the CAS so I'm assuming its simplify

image I also saw this somewhere (TIPlanet I think)

adriweb commented 1 year ago

Hmm from the screenshots in the readme, I guess it could be. if you try things from the screenshots, does it work for you?

it's a bit surprising considering your examples seem simpler...

hypersonicstorm commented 1 year ago

Most of them (all of them not including the factoring ones) work

Also I'm pretty sure simplify includes factoring image

hypersonicstorm commented 1 year ago

I believe this issue was fixed before here so I might be using the program wrong

nathanfarlow commented 1 year ago

Yep factoring polynomials isn't supported as a simplify operation currently