search

nathanford / widowadjust

Hate typographic widows hanging around on your site? Use this. See it in action on artequalswork.com
MIT License
347 stars 27 forks source link

Requires line-height to be set to work (Chrome 64 Mac OS X) #5

Open jonjhiggins opened 6 years ago

jonjhiggins commented 6 years ago

I guess this repo has been superseded by type.js but was just giving it a spin (I only wanted the widow functionality) and figured this info might be useful for someone doing the same:

I noticed that the widow functionality only worked when a line-height is supplied:

No line-height: https://codepen.io/jonjhiggins/pen/WMZdpM Line-height: https://codepen.io/jonjhiggins/pen/KQXXbd

This looks to be due to Chrome specifying the line-height in JS as 'normal' instead of a number, causing getstyle to return NaN

jpamental commented 6 years ago

Nice find Jon - thanks for reporting back! I use it just for that reason as well.

Jason

On Feb 14, 2018, at 10:47 PM, Jon Higgins notifications@github.com wrote:

I guess this repo has been superseded by type.js but was just giving it a spin (I only wanted the widow functionality) and figured this info might be useful for someone doing the same:

I noticed that the widow functionality only worked when a line-height is supplied:

No line-height: https://codepen.io/jonjhiggins/pen/WMZdpM https://codepen.io/jonjhiggins/pen/WMZdpM Line-height: https://codepen.io/jonjhiggins/pen/KQXXbd https://codepen.io/jonjhiggins/pen/KQXXbd This looks to be due to Chrome specifying the line-height in JS as 'normal' instead of a number, causing getstyle to return NaN

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nathanford/widowtamer/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgzRYytsLVaRvGuOF0gEgW9-pC1jbKZks5tU6jSgaJpZM4SGTh_.