nathanhi / pyfatfs

Python based FAT12/FAT16/FAT32 implementation with VFAT support
https://pypi.org/project/pyfatfs/
MIT License
29 stars 14 forks source link

Add Python 3.12 compatibility, drop Python 3.7 (EOL) #36

Closed zurcher closed 11 months ago

zurcher commented 11 months ago

This solves the following error when installing from source with pip install -e:

AttributeError: module 'pkgutil' has no attribute 'ImpImporter'.

Tested with Python 3.12 and 3.10.11.

zurcher commented 11 months ago

Python 3.7 is EOL: https://devguide.python.org/versions/

nathanhi commented 11 months ago

Thank you once again! :partying_face: Sorry for the delay releasing the upcoming package!

nathanhi commented 11 months ago

Seems like the tests are failing in Python 3.12 due to the usage of deprecated / removed test methods in PyFilesystem2:

https://github.com/PyFilesystem/pyfilesystem2/issues/568

I've added a workaround until this gets fixed upstream.

zurcher commented 11 months ago

Thanks for cleaning this up!