Closed AntoineChwat closed 11 months ago
Thanks for this! Just approved workflow runs so tests can run.
Getting the following error in the pnpm logs:
"4 error pnpm": {
"code": "ERR_PNPM_SPEC_NOT_SUPPORTED_BY_ANY_RESOLVER",
"pkgsStack": [],
"err": {
"name": "Error",
"message": "eslint@\">=7.2.0 isn't supported by any available resolver.",
"code": "ERR_PNPM_SPEC_NOT_SUPPORTED_BY_ANY_RESOLVER",
"stack": "Error: eslint@\">=7.2.0 isn't supported by any available resolver.\n at Object.resolve (/usr/local/lib/node_modules/pnpm/dist/pnpm.cjs:79357:17)\n at async run (/usr/local/lib/node_modules/pnpm/dist/pnpm.cjs:65440:23)"
}
}
But I can't for the life of me debug the tape tests to see what fails, it looks like the version range is truncated somehow but I don't get how/why it only fails with pnpm
This time around I just added the ranges as is and let the package managers get the latest versions from that, it makes for a more verbose package.json but at least it insures that we get the right version no problem.
@ljharb it looks like the tests are passing, so I'm comfortable with cutting a new release. Should this be a patch release?
@nathanhleung it looks fine i think, but the only test change is in a pnpm fixture. Shouldn't this have regression tests?
Attempting to fix dependency order bug.
Fixes #150.