nathanhleung / install-peerdeps

💻 A command-line interface to install an NPM package and its peer dependencies automatically.
https://www.npmjs.com/package/install-peerdeps
MIT License
296 stars 20 forks source link

issue-150 - Fixed bug. #153

Closed AntoineChwat closed 11 months ago

AntoineChwat commented 3 years ago

Attempting to fix dependency order bug.

Fixes #150.

nathanhleung commented 3 years ago

Thanks for this! Just approved workflow runs so tests can run.

AntoineChwat commented 3 years ago

Getting the following error in the pnpm logs:

  "4 error pnpm": {
    "code": "ERR_PNPM_SPEC_NOT_SUPPORTED_BY_ANY_RESOLVER",
    "pkgsStack": [],
    "err": {
      "name": "Error",
      "message": "eslint@\">=7.2.0 isn't supported by any available resolver.",
      "code": "ERR_PNPM_SPEC_NOT_SUPPORTED_BY_ANY_RESOLVER",
      "stack": "Error: eslint@\">=7.2.0 isn't supported by any available resolver.\n    at Object.resolve (/usr/local/lib/node_modules/pnpm/dist/pnpm.cjs:79357:17)\n    at async run (/usr/local/lib/node_modules/pnpm/dist/pnpm.cjs:65440:23)"
    }
  }

But I can't for the life of me debug the tape tests to see what fails, it looks like the version range is truncated somehow but I don't get how/why it only fails with pnpm

AntoineChwat commented 3 years ago

This time around I just added the ranges as is and let the package managers get the latest versions from that, it makes for a more verbose package.json but at least it insures that we get the right version no problem.

nathanhleung commented 3 years ago

@ljharb it looks like the tests are passing, so I'm comfortable with cutting a new release. Should this be a patch release?

ljharb commented 3 years ago

@nathanhleung it looks fine i think, but the only test change is in a pnpm fixture. Shouldn't this have regression tests?