Convert id values from strings to ints

nathanhosselton / DadKit

The network+model layer for the http://raiddad.com native iOS app: https://apps.apple.com/us/app/raid-dad/id1441280856

13 stars 0 forks source link

Convert id values from strings to ints #4

Open nathanhosselton opened 5 years ago

nathanhosselton commented 5 years ago

e.g. https://github.com/nathanhosselton/DadKit/blob/c4cf1d0e7c6dbd8bfee53785c9e158fa463c069d/DadKit/Player.swift#L19

nathanhosselton commented 5 years ago

[ ] Don't forget to update the jazzy docs.

nathanhosselton commented 5 years ago

@b3ll what specific properties are you looking for type conversions on here? I just looked through and I don't even see any that I publicly expose except for on Clan. So I can expose some if you need them, and make them ints.

b3ll commented 5 years ago

@nathanhosselton ideally either exposing the membershipID as an Int or making Player, Clan, and Member all conform to Hashable, Equatable, etc so lookups are possible in Collections (see the DataKitExtensions file in Raid Dad)

nathanhosselton commented 5 years ago

@b3ll Will the changes in that commit fit the bill? Any need to still expose the unique identifiers?