Not working with more than one display

PaulMorris commented 3 years ago

Thanks for this helpful extension. It works well if there's only one display active, but if I'm using both an external display and my laptop display, it no longer works. Hitting space to show/hide the letters works, but typing a letter doesn't do anything, and hitting shift (to close) doesn't do anything. Just wanted to report the bug, in case you weren't aware of it.

nathanielsimard commented 3 years ago

Hi, I cannot reproduce the bug on Gnome-3.38 with the new fixes on #31. What is your setup exactly?

cavenditti commented 3 years ago

Same problem here. It only happens when Gnome is set to switch workspaces only on the main display. Looking at logs I get:

DEBUG - [Overview Navigation - CustomWorkspaceView] On key press ...
DEBUG - [Overview Navigation - CustomWorkspaceView] On key release ...

but it never gets to WindowSelector.

Maybe the problem comes somehow from the need to call isOnFirstMonitor in customWorkspaceView.js? I just gave a quick look to the code and I don't know how this works so I might be completely wrong about it.

EDIT: Ok, this is weird, it is working now and cannot reproduce it anymore. Just suspended the computer and now it's working.

razcore-rad commented 3 years ago

I was looking at this, I can confirm that by switching from Workspaces on primary display only to Workspaces span displays in Tweaks the extension works.

The extension doesn't work with Workspaces on primary display only set to true.

As far as I can tell that's because isOnFirstMonitor(), like it was mentioned.

I'm on Ubuntu 20.10, Gnome Version 3.38.3, X11.

I don't know where to check the extension version so here's metadata.json instead:

{
  "_generated": "Generated by SweetTooth, do not edit",
  "description": "This extension aims to make Gnome Shell easier to navigate using only the keyboard. It is inspired by the vim plugins of Firefox and Chrome.",
  "name": "Overview Navigation",
  "settings-schema": "org.gnome.shell.extensions.overview-navigation",
  "shell-version": [
    "3.38"
  ],
  "url": "https://github.com/nathanielsimard/overview-navigation",
  "uuid": "overview-navigation@nathanielsimard.github.com",
  "version": 14
}

I added a log to check for isOnFirstMonitor() and I know it returns false when Workspaces on primary display only is enabled:

May 27 09:34:16 alienware gnome-shell[4099]: DEBUG - [Overview Navigation - CustomWorkspaceView] RAZ: false

isOnFirstMonitor() returns true otherwise.

Now this doesn't affect me really cause I don't use workspaces, but hope this helps.

nathanielsimard / overview-navigation

Not working with more than one display #30