nathanielvarona / pritunl-client-github-action

Establish automated secure Pritunl VPN connections with Pritunl Client in GitHub Actions, supporting OpenVPN and WireGuard.
https://github.com/marketplace/actions/pritunl-client-github-action
MIT License
19 stars 5 forks source link

Wrong Establishing connection calculations #114

Closed avramenkovladyslav closed 7 months ago

avramenkovladyslav commented 1 year ago

Issue Description

If established-connection-timeout set, then it will require another time in seconds unlike what is specified and checks step increased each time in geometry progression, but steps count will be correct

  1. set established-connection-timeout 180
  2. trigger workflow
  3. see how long it will require to process (more than 10 minutes)

or

  1. set established-connection-timeout 10
  2. trigger workflow
  3. will be completed less than 10 seconds

checks equals seconds

checks not equals seconds

Used latest version with nathanielvarona/pritunl-client-github-action@main which equals 1.4.3

It has been used with the following parameters:

Runner Virtual Environments:

VPN Modes:

Client Versions:

Start Connection: If the connection is started on the setup step.

Runner Types:

nathanielvarona commented 9 months ago

Hello @avramenkovladyslav,

The input established-connection-timeout currently (as of release v1.4.3) is based on the number of probes/checks and not a timely-based unit (seconds).

I'll be working on that sooner or later using the time unit as our timeout.

Please star/watch the project to keep updated on the latest releases including the improvement/fixes of the current issue(s).

nathanielvarona commented 7 months ago

Closing the Issue Fixed from #133