search

nathanjhood / Biquads

Simple two-pole equalizer with variable oversampling.
https://www.stoneydsp.com/projects/biquads
GNU General Public License v3.0
13 stars 1 forks source link

Wip/optimize parameters #87

Open nathanjhood opened 5 months ago

nathanjhood commented 5 months ago

What kind of change does this PR introduce?

nathanjhood commented 5 months ago

Oh look, the CI/CD failed. No worries, the logs can help us determine the cause of failure so that we can reproduce, fix, create tests, and deploy a patch. Let's see what the logs say!

SEGFAULT
nathanjhood commented 5 months ago

More seriously, strange that the build succeeded but it was pluginval which failed by SEGFAULTing.

Suggests that perhaps the array index went out of bounds for some reason. That, or possibly a pointer to a non-valid object... well, whatever it is, at least we have some really helpful and informative information to begin our search with:

SEGFAULT
nathanjhood commented 5 months ago

We'd probably have learned the cause of the issue whilst avoiding it, had we used the vector container template class and unique pointers.

Let's try it with std lib.