The Scoop Project Review: Summary - Githubissues

nathanjwtx / codecademy_projects

Projects from Codecademy courses

0 stars 0 forks source link

The Scoop Project Review: Summary #1

Open SidTheEngineer opened 6 years ago

SidTheEngineer commented 6 years ago

Rubric Score

Criteria 1: Node.js Project Structure

Score Level: 4/4
Comment(s): NodeJS project structure looks perfect. Starter code + new code, testing suite, package.json, etc. are all included.

Criteria 2: Implementation of API Specification and Functionality

Score Level: 3.5/4
Comment(s): API functionality works just about perfectly. I had no issues creating/deleting comments, upvoting, downvoting, etc. One minor issue I was having was editing comments. Currently, a 400 code is being thrown when trying to edit a comment. Take a look at the updateComment function and see if you can spot any issues.

Criteria 3: Test Case Results (Are all Test Cases Passing?)

Score Level: 3/4
Comment(s): Related to the previous comment, the updateComment function isn't properly returning a 200. Beyond this, all test cases are passing.

Criteria 4: JavaScript Fundamentals and Formatting

Score Level: 4/4
Comment(s): Javascript fundamentals/syntax/formatting look great. I don't see any glaring issues with your code here 👍

Criteria 5 (Optional): YAML Database Saving/Loading

Score Level: 4/4
Comment(s): Great work implementing the saving/loading feature. The code looks good and the feature works appropriately.

Overall Score: 18.5/20 👏

Overall great work with the project! The only minor area for improvement I noticed was in the updateComment function, as mentioned.

nathanjwtx commented 6 years ago

Hi Sid, thanks for reviewing my project. I believe I have fixed the issue with the comment function.