Closed Debenben closed 2 years ago
This is interesting, thanks. I have two move hubs myself and tested it with both, and they both experience this (also great explanation!).
One question, did you validate whether it happened on an earlier firmware revision? Its fine if not, just wondering whether to put a firmware guard around it (it appears 1.1.00.0000 has been around a long time though, not sure if I can even recall an earlier version).
I remember that some of my technic hubs used to have a different firmware version when I got them. With the official lego app all of them updated themselves to 1.1.00.0000 and I don't have any hubs with different or old firmware to test with.
Before merging this it would be good if someone else can confirm that they also see the same problem. All my technicmediumhubs have this issue and I can use this workaround to correct it, but it could be that e.g. all my hubs are from some batch that has been put upside down in some factory calibration routine or maybe this is some bug in the firmware that is fixed by lego already and I simply use outdated firmware.
The problem is the following: If the hub was an airplane, then the z angle of the tilt would be the heading angle. If the airplane flies straight into the ground or straight up, the heading is undefined, one can chose any value. However the roll angle which is x is not undefined, but it depends on the choice of heading angle which defines from what angle to start applying the roll. This is what seems to be wrong in the values the hub reports. In the pull request I chose to correct the heading, one could choose to leave it as is and instead apply the same operation to the x angle.