nathankot / company-sourcekit

Completion for Swift projects via SourceKit with the help of SourceKitten
207 stars 16 forks source link

Why not silent the message when writing to the tmp file? #23

Closed galeo closed 7 years ago

galeo commented 7 years ago

Hi, @nathankot

I've seen the latest two commits (6c0c783 and 0c3ccf9) by you trying to silent the writing message and then reverted. Maybe the code (write-region (point-min) (point-max) tmpfile 'silent) in 6c0c783 was wrong:

The arguments for write-region:

(write-region START END FILENAME &optional APPEND VISIT LOCKNAME MUSTBENEW)

The optional fourth argument APPEND should be set to nil. The right code should be: (write-region (point-min) (point-max) tmpfile nil 'silent) .

Could we turn off the writing message which is really annoying?

Thanks and happy new year :)

nathankot commented 7 years ago

@galeo I'm not sure why I reverted that commit, I remember it broke something under a certain condition.

It seems like you've managed to get it working though? Feel free to submit a pull-request for this fix - I'd much prefer the community contribute than just make issues for these things :)

galeo commented 7 years ago

Thanks and I'm glad to make a contribution next time :)