:up: Update travis rubies

nathanl / authority

*CURRENTLY UNMAINTAINED*. Authority helps you authorize actions in your Rails app. It's ORM-neutral and has very little fancy syntax; just group your models under one or more Authorizer classes and write plain Ruby methods on them.

MIT License

1.21k stars 67 forks source link

:up: Update travis rubies #116

Closed sanemat closed 7 years ago

sanemat commented 7 years ago

Add ruby 2.3
Add ruby 2.4
Avoid errors on edge case

Next step: Update rspec to v3

christhekeele commented 7 years ago

Would the rake issue be better avoided by bumping the development dependency in the .gemspec instead to 11.3? Would we need to pin it to under 12.0? I'm not really clear where last_comment is coming into play.

sanemat commented 7 years ago

@christhekeele I think pinning rake v11.3 is temporary solution, so I don't add this to original .gemspec. This is rspec v2 issue, we should update rspec to v3, soon :)

christhekeele commented 7 years ago

Just to clarify, if we bumped rspec, then these rake changes wouldn't be necessary? I think I'd rather have the full fix later then a larger matrix of ruby versions sooner.

sanemat commented 7 years ago

Answer is yes, rspec 2.14 uses ::Rake.application.last_comment. https://travis-ci.org/nathanl/authority/jobs/190024617#L212 https://github.com/rspec/rspec-core/blob/2-14-maintenance/lib/rspec/core/rake_task.rb#L118

I agree with shrinking ruby/rails version! I also think we want to have green test first.