search

nathanlea / HotelReservation

0 stars 0 forks source link

What Changes the Itinerary Pending -> Approved #12

Closed nathanlea closed 8 years ago

nathanlea commented 8 years ago

What is the answer to this? @dvglynn

nathanlea commented 8 years ago

Could we add something to the database to do this? @kdangel

kdangel commented 8 years ago

We can definitely make it happen. When data drives the app it is always easier to make things more dynamic. From what I can tell in the screen references, we are just wanting the views to represent to states, pending, and approved. Is this just the map images that are different? I can add an attribute to the reservation table that leaves the the status in three states, approved, not approved, and pending. I wouldn't probably want to use a nullable boolean because null values are harder to code against. But, since we have only the two views, we could get away with a cancelled/denied status. I will go ahead and add the changes to the table and class model, Let me know your thoughts on what we want to do with the info.

-Kevin

From: nathanlea notifications@github.com Sent: Friday, November 20, 2015 5:41 PM To: nathanlea/HotelReservation Cc: Angel, Kevin D Subject: Re: [HotelReservation] What Changes the Itinerary Pending -> Approved (#12)

Could we add something to the database to do this? @kdangelhttps://github.com/kdangel

[https://avatars0.githubusercontent.com/u/14020444?v=3&s=400]https://github.com/kdangel

kdangel Follow kdangel on GitHub and watch them build beautiful projects. Read more...https://github.com/kdangel

Reply to this email directly or view it on GitHubhttps://github.com/nathanlea/HotelReservation/issues/12#issuecomment-158559158.

kdangel commented 8 years ago

Sorry forgot the cc part.

From: nathanlea notifications@github.com Sent: Friday, November 20, 2015 5:41 PM To: nathanlea/HotelReservation Cc: Angel, Kevin D Subject: Re: [HotelReservation] What Changes the Itinerary Pending -> Approved (#12)

Could we add something to the database to do this? @kdangelhttps://github.com/kdangel

[https://avatars0.githubusercontent.com/u/14020444?v=3&s=400]https://github.com/kdangel

kdangel Follow kdangel on GitHub and watch them build beautiful projects. Read more...https://github.com/kdangel

Reply to this email directly or view it on GitHubhttps://github.com/nathanlea/HotelReservation/issues/12#issuecomment-158559158.

kdangel commented 8 years ago

I am about to blow away and rebuild the database to include some more info for

Changing:

Hotels, MeetingRooms, ReservationInfo,

Adding :

EquipmentTable, CateringTable

So if you can, try to keep from testing for a sec While I rebuild it. I will give an all clear once done.

-Kevin

From: Angel, Kevin D Sent: Friday, November 20, 2015 8:25 PM To: nathanlea/HotelReservation; nathanlea/HotelReservation Cc: Connor Eaves; Glynn, Derrian Vaughn; Kasuvajjala, Deepthi Subject: Re: [HotelReservation] What Changes the Itinerary Pending -> Approved (#12)

Sorry forgot the cc part.

From: nathanlea notifications@github.com Sent: Friday, November 20, 2015 5:41 PM To: nathanlea/HotelReservation Cc: Angel, Kevin D Subject: Re: [HotelReservation] What Changes the Itinerary Pending -> Approved (#12)

Could we add something to the database to do this? @kdangelhttps://github.com/kdangel

[https://avatars0.githubusercontent.com/u/14020444?v=3&s=400]https://github.com/kdangel

kdangel Follow kdangel on GitHub and watch them build beautiful projects. Read more...https://github.com/kdangel

Reply to this email directly or view it on GitHubhttps://github.com/nathanlea/HotelReservation/issues/12#issuecomment-158559158.

nathanlea commented 8 years ago

That sounds great to me, thanks for updating this. And the maps are pulled in from the hotel location but at the moment just a simple hard coded picture is going to half to do. On Nov 20, 2015 8:24 PM, "kdangel" notifications@github.com wrote:

We can definitely make it happen. When data drives the app it is always easier to make things more dynamic. From what I can tell in the screen references, we are just wanting the views to represent to states, pending, and approved. Is this just the map images that are different? I can add an attribute to the reservation table that leaves the the status in three states, approved, not approved, and pending. I wouldn't probably want to use a nullable boolean because null values are harder to code against. But, since we have only the two views, we could get away with a cancelled/denied status. I will go ahead and add the changes to the table and class model, Let me know your thoughts on what we want to do with the info.

-Kevin

From: nathanlea notifications@github.com Sent: Friday, November 20, 2015 5:41 PM To: nathanlea/HotelReservation Cc: Angel, Kevin D Subject: Re: [HotelReservation] What Changes the Itinerary Pending -> Approved (#12)

Could we add something to the database to do this? @kdangel< https://github.com/kdangel>

[https://avatars0.githubusercontent.com/u/14020444?v=3&s=400]< https://github.com/kdangel>

kdangel Follow kdangel on GitHub and watch them build beautiful projects. Read more...https://github.com/kdangel

Reply to this email directly or view it on GitHub< https://github.com/nathanlea/HotelReservation/issues/12#issuecomment-158559158

.

— Reply to this email directly or view it on GitHub https://github.com/nathanlea/HotelReservation/issues/12#issuecomment-158577785 .

kdangel commented 8 years ago

DB is good to go for now. Looks like we had an issue with csx for a small time frame. I have a sneaking suspicion this may be a problem on Demo day, or maybe Mayfield will try to sabotage us. Who knows... Murphy's Law..... But we can always point to a local db if needed. I can work on a repo change for that. But for now it seems that csx.okstate is back up and working so test away!

From: nathanlea notifications@github.com Sent: Friday, November 20, 2015 10:12 PM To: nathanlea/HotelReservation Cc: Angel, Kevin D Subject: Re: [HotelReservation] What Changes the Itinerary Pending -> Approved (#12)

That sounds great to me, thanks for updating this. And the maps are pulled in from the hotel location but at the moment just a simple hard coded picture is going to half to do. On Nov 20, 2015 8:24 PM, "kdangel" notifications@github.com wrote:

We can definitely make it happen. When data drives the app it is always easier to make things more dynamic. From what I can tell in the screen references, we are just wanting the views to represent to states, pending, and approved. Is this just the map images that are different? I can add an attribute to the reservation table that leaves the the status in three states, approved, not approved, and pending. I wouldn't probably want to use a nullable boolean because null values are harder to code against. But, since we have only the two views, we could get away with a cancelled/denied status. I will go ahead and add the changes to the table and class model, Let me know your thoughts on what we want to do with the info.

-Kevin

From: nathanlea notifications@github.com Sent: Friday, November 20, 2015 5:41 PM To: nathanlea/HotelReservation Cc: Angel, Kevin D Subject: Re: [HotelReservation] What Changes the Itinerary Pending -> Approved (#12)

Could we add something to the database to do this? @kdangel< https://github.com/kdangel>

[https://avatars0.githubusercontent.com/u/14020444?v=3&s=400]< https://github.com/kdangel>

kdangel Follow kdangel on GitHub and watch them build beautiful projects. Read more...https://github.com/kdangel

Reply to this email directly or view it on GitHub< https://github.com/nathanlea/HotelReservation/issues/12#issuecomment-158559158

.

Reply to this email directly or view it on GitHub https://github.com/nathanlea/HotelReservation/issues/12#issuecomment-158577785 .

Reply to this email directly or view it on GitHubhttps://github.com/nathanlea/HotelReservation/issues/12#issuecomment-158586340.

kdangel commented 8 years ago

Me and CC don't get along sometimes....

From: Angel, Kevin D Sent: Friday, November 20, 2015 11:37 PM To: nathanlea/HotelReservation; nathanlea/HotelReservation Subject: Re: [HotelReservation] What Changes the Itinerary Pending -> Approved (#12)

DB is good to go for now. Looks like we had an issue with csx for a small time frame. I have a sneaking suspicion this may be a problem on Demo day, or maybe Mayfield will try to sabotage us. Who knows... Murphy's Law..... But we can always point to a local db if needed. I can work on a repo change for that. But for now it seems that csx.okstate is back up and working so test away!

From: nathanlea notifications@github.com Sent: Friday, November 20, 2015 10:12 PM To: nathanlea/HotelReservation Cc: Angel, Kevin D Subject: Re: [HotelReservation] What Changes the Itinerary Pending -> Approved (#12)

That sounds great to me, thanks for updating this. And the maps are pulled in from the hotel location but at the moment just a simple hard coded picture is going to half to do. On Nov 20, 2015 8:24 PM, "kdangel" notifications@github.com wrote:

We can definitely make it happen. When data drives the app it is always easier to make things more dynamic. From what I can tell in the screen references, we are just wanting the views to represent to states, pending, and approved. Is this just the map images that are different? I can add an attribute to the reservation table that leaves the the status in three states, approved, not approved, and pending. I wouldn't probably want to use a nullable boolean because null values are harder to code against. But, since we have only the two views, we could get away with a cancelled/denied status. I will go ahead and add the changes to the table and class model, Let me know your thoughts on what we want to do with the info.

-Kevin

From: nathanlea notifications@github.com Sent: Friday, November 20, 2015 5:41 PM To: nathanlea/HotelReservation Cc: Angel, Kevin D Subject: Re: [HotelReservation] What Changes the Itinerary Pending -> Approved (#12)

Could we add something to the database to do this? @kdangel< https://github.com/kdangel>

[https://avatars0.githubusercontent.com/u/14020444?v=3&s=400]< https://github.com/kdangel>

kdangel Follow kdangel on GitHub and watch them build beautiful projects. Read more...https://github.com/kdangel

Reply to this email directly or view it on GitHub< https://github.com/nathanlea/HotelReservation/issues/12#issuecomment-158559158

.

Reply to this email directly or view it on GitHub https://github.com/nathanlea/HotelReservation/issues/12#issuecomment-158577785 .

Reply to this email directly or view it on GitHubhttps://github.com/nathanlea/HotelReservation/issues/12#issuecomment-158586340.