Enable linting - Githubissues

nathanleiby / drum-break

Drum training tool

https://drumbreak.nathanleiby.me/

0 stars 0 forks source link

Enable linting #5

Closed nathanleiby closed 1 week ago

nathanleiby commented 2 weeks ago

Why: Want to improve the quality of the Rust codebase.

How:

add Clippy setup locally, to enforce better rust practices
add Clippy to CI

nathanleiby commented 1 week ago

Resolved here: https://github.com/nathanleiby/drum-break/compare/f07430d39316c7113e19fe2fa79f62c8c98d8990..823a795

Reminder that Github Actions seem to be running latest Rust (1.82) without any explicit configuration locking, whereas I was running 1.80 locally. Because of this, there were a handful of Clippy errors caught that I didn't see locally. Neat that there's progress! But ideally can align versions for consistency in future.