nathanmarks / jss-theme-reactor

NOT MAINTAINED Powerful theming layer for use with the jss CSS in JS library
MIT License
64 stars 6 forks source link

Update cross-env to the latest version πŸš€ #36

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 4.0.0 of cross-env just got published.

Dependency cross-env
Current Version 3.2.4
Type devDependency

The version 4.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of cross-env. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Release Notes v4.0.0

4.0.0 (2017-03-31)

Bug Fixes

  • Resolve value of env variables before invoking cross-spawn (#95) (e8a16146)
  • Remove Windows => UNIX variable conversion (#94) (0a846e60)
  • module: Add export for commonjs (#88) (22d1c801)

Features

  • Convert list delimiters for PATH-style env variables (#93) (ea0ac4bd)
  • args: convert embedded and braced variables in command args (#86) (1b172fef)
  • spawn: add support for quoted scripts (ea800213)

Breaking Changes

  • This is unlikely to break anyone, but now if you assign a variable to a variable (like FOO=$BAR with the value $BAR being assigned to hello, the command will be converted to FOO=hello whereas before it was FOO=$BAR).
    (e8a16146)
  • %windows_style% env variables will no longer be converted to $unix_style in UNIX machines. To fix it, use always the UNIX syntax, cross-env will change the format in Windows machines as needed
    (0a846e60)
  • If an env variable has : or ; in its value, it will be converted to : on UNIX
    systems or ; on Windows systems. To keep the old functionality, you will need to escape those
    characters with a backslash.

#80

  • chore: Add myself (DanReyLop) to the contributors list

  • Simplified logic. Now only : (UNIX-style) are converted to ; (Windows-style), not the other way around

BREAKING CHANGE: You now must escape : to use it in a value of you don't want it to be swapped with ; on Windows
(ea0ac4bd)

  • Changes the behavior when passed quoted scripts or special characters interpreted by the shell.
    (ea800213)
  • echo $var2/$var1 would not be changed on windows, now it is. This is kind of a bug, but we're doing a major version bump to be safe.
    (1b172fef)
Commits

The new version differs by 7 commits .

  • e8a1614 fix: Resolve value of env variables before invoking cross-spawn (#95)
  • 9e0ea05 docs(engine): revert support to node 4 (#96)
  • 0a846e6 fix: Remove Windows => UNIX variable conversion (#94)
  • ea0ac4b feat: Convert list delimiters for PATH-style env variables (#93)
  • ea80021 feat(spawn): add support for quoted scripts
  • 22d1c80 fix(module): Add export for commonjs (#88)
  • 1b172fe feat(args): convert embedded and braced variables in command args (#86)

See the full diff.

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

codecov[bot] commented 7 years ago

Codecov Report

Merging #36 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files           4        4           
  Lines         117      117           
=======================================
  Hits          106      106           
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 27f58a9...980f085. Read the comment docs.