Open RikardGehlin opened 6 years ago
as far as API surface isn't changed it's not a breaking change for consumers, but it's sort of big deal, so perhaps it's a minor release
Merging #46 into master will increase coverage by
0.09%
. The diff coverage is90.9%
.
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 94.11% 94.21% +0.09%
==========================================
Files 4 4
Lines 119 121 +2
==========================================
+ Hits 112 114 +2
Misses 7 7
Impacted Files | Coverage Δ | |
---|---|---|
src/styleManager.js | 96.92% <ø> (+1.03%) |
:arrow_up: |
src/ThemeProvider.js | 80.76% <90.9%> (+5.76%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3fc03b1...2b9fc6c. Read the comment docs.
i dont know how to fix flow errors
@nathanmarks can you help?
I think you should wait a bit, because @oliviertassinari is cooking something in this regard.
sure, but we migrated it and fixed the breaking changes. we just dont know how to fix flow erros
we need this because we need latest jss checked out in our projects for it to be possible to migrate to react-jss's theming
btw, published as @iamstarkov/jss-theme-reactor@0.12.0
I'm working on a major styling upgrade on the Material-UI side, we would no longer rely on jss-theme-reactor
. Some of the features this rewrite is unlocking:
@oliviertassinari thats cool, but we do use jss-theme-reactor without material-ui, so we need release of jss-theme-reactor to depend on latest jss, so we can migrate to react-jss's theming. can we get such a release?
so, just clarify we dont need new material-ui release, we need new release of jss-theme-reactor
@iamstarkov Oh but I don't have any admin right on this repository.
@nathanmarks can you help?
@nathanmarks ping
Also fixed breaking changes from migration between 7.1.7 to 8.1.0 https://github.com/cssinjs/jss/blob/v8.1.0/changelog.md#800--2017-06-20
breaking changes were: