search

nathanmarks / jss-theme-reactor

NOT MAINTAINED Powerful theming layer for use with the jss CSS in JS library
MIT License
64 stars 6 forks source link

React is included in published ThemeProvider.js #7

Closed jcperez-ch closed 7 years ago

jcperez-ch commented 7 years ago

This is more like a clarification, not sure if this was intended.

But when I install hss-theme-reactor to be used in a vanillaJS project or even in a angularJS project it installs react as dependency:

var _react = require('react');

Since the ThemeProvider is a React component. Wouldn't be good to specify in the readme the dependency to react? So people is aware of the use of react even for angular or vueJS projects.

nathanmarks commented 7 years ago

It doesn't install React as a dependency, just a devDependency.

I'm going to remove the ThemeProvider re-export so it isn't in the index.js entry point.