search

nathanmarks / vrtest

MIT License
14 stars 3 forks source link

Use image-difference over image-diff #4

Open oliviertassinari opened 7 years ago

oliviertassinari commented 7 years ago

image-diff is no longer maintained, I ended up rewriting it with the latest node standard. image-difference should run x4 faster based on the benchmark.

nathanmarks commented 7 years ago

@oliviertassinari thanks, I will update it soon

nicgirault commented 6 years ago

What about pixelmatch? It seems to have a stronger community and is described as "blazing fast".

oliviertassinari commented 6 years ago

I have been benchmarking it in https://github.com/argos-ci/image-difference#benchmark. It's slower than the alternatives.

oliviertassinari commented 6 years ago

@nicgirault But to be fair, vrtest is not maintained, the only project using, I'm aware of, is Material-UI and we don't use the diff option, we are just taking the screenshots. In different projects, I have been taking the screenshots with puppeteer or capybara during e2e tests or with happo for the components.

nicgirault commented 6 years ago

@oliviertassinari vrtest seems very promising to me. It's the only test runner I find in the image screenshot ecosystem that use selenium (I noted that most of visual regression in my projects occurs on browsers that developers don't use: Edge etc so I don't want to use puppeteer & co and would prefer to use Browserstack). Would you use something else to answer this need? After spending some time searching for a good stack I came to the conclusion that vrtest deserve to be maintained.

I also don't use diff option for now and I think this issue is not a priority compared to documenting this lib.

oliviertassinari commented 6 years ago

@nicgirault We push the screenshots to Argos-CI (it's open source), for instance: https://www.argos-ci.com/mui-org/material-ui/builds/26903. We have some integration examples: https://github.com/argos-ci/argos/tree/master/examples in case you are looking for a good "stack".

oliviertassinari commented 6 years ago

I came to the conclusion that vrtest deserve to be maintained

At least, it's working pretty well, it has been battle tested for a year+, I have no issue to repport.

oliviertassinari commented 6 years ago

In case you didn't know about Argos-CI, it's a small project, there is like 10+ active users right now:

It was developed by me and @neoziro. We haven't put a lot of resource into it recently. It's answering our needs. The plan so far is to follow the Sentry business model (Open Source + paid hosting for people that look for peace of mind), at least, if we can get users traction.

nathanmarks commented 6 years ago

@oliviertassinari I spoke to @nicgirault over email, we're going to make some updates to this library.

I'm going to rewrite in TS and then we'll work on some feature changes.

oliviertassinari commented 6 years ago

Great!