search

nathanmarz / cascalog

Data processing on Hadoop without the hassle.
Other
1.38k stars 179 forks source link

Fix tests of TextDelimited quoting behavior. #209

Closed ghost closed 10 years ago

ghost commented 10 years ago

It seems that a faulty unit test slipped in the more-taps test suite. The test was missing an => and thus always successful.

Fixing the test though causes it to fail, as the behaviour of TextDelimited has changed to match the CSV spec more closely. This (unexpected) behavior has been dicussed in #150.

This patch adjusts the tests to match the new behavior.

Note though that the way TextDelimited writes fields is still not in compliance with the specification, this is documented and tested as well.

Inspection of this patch by @Quantisan is probably advisable.

Quantisan commented 10 years ago

thanks for the detailed explanation