Closed r0man closed 10 years ago
@sritchie quick question: is it a design choice to make all parameters be passed in via anonymous function, or is passing param directly and mixing with var still acceptable? e.g. ((get-in* [:a]) ?m :> ?out) vs (get-in ?m [:a] :> ?out)
Hey, just saw this - it's acceptable to mix, and this example does need to pass.
The old syntax that's now gone was passing in higher-order parameters with the vector in the first position. That was a cascalog-only thing that didn't map into clojure.
Now, you can either pass in parameters directly via the vector, or create a closure. This is definitely a bug.
I'm not sure of the fix exactly yet, but the source of the bug is here:
When the vector arg is added as an Insert, jacknife.seq/flatten is getting called on it.
Thanks for fixing this!
Can we get a new release? This fix was blocking our codebase to update to Cascalog 2. Now everything is cool and all tests are passing. Thanks again.
+1 on getting this into a new release -- we are in the same positon w/r/t to upgrading. thanks!
I'm happy to do a soft 2.0.1 release, i.e., just do the release and pushing to clojars. the only thing that's been holding me back is that I haven't had time to write an annoucemt email and change log
On Monday, March 10, 2014, dollschasingmen notifications@github.com wrote:
+1 on getting this into a new release -- we are in the same positon w/r/t to upgrading. thanks!
Reply to this email directly or view it on GitHubhttps://github.com/nathanmarz/cascalog/issues/217#issuecomment-37249208 .
at neat, thanks -- i think we are going to roll w/ 2.01-SNAPSHOT for now, but would be great if this was an official release. get-in is huge for us :)
Hello everyone,
I think there is something broken when using vectors as arguments within a Cascalog query. This query used to work in 1.10.2 but fails with 2.0.0:
In Cascalog 2.0.0 I get a java.lang.IllegalArgumentException exception, with the appended stacktrace. I added a test case for this problem over here:
https://github.com/r0man/cascalog/blob/broken-args/cascalog-core/test/cascalog/api_test.clj#L1020
Roman