search

nathanmarz / cascalog

Data processing on Hadoop without the hassle.
Other
1.38k stars 178 forks source link

Tests for GlobHfs glob strings #255

Closed bhiles closed 9 years ago

bhiles commented 10 years ago

Potential fix for #181.

I'm a little unsure on what you were looking for in this issue, so here is an attempt. Let me know how I can modify this to better suit the issue.

Quantisan commented 10 years ago

@bhiles I think #181 refers to a trailing slash, perhaps you could add that into your test please?

bhiles commented 10 years ago

@Quantisan Thanks for taking a look at this.

I have a test in place, here, to show the trailing slash doesn't make a difference.

One potential downside to these tests, they are dependent on the src directory keeping the same structure (only including 2 directories: clj and java), so if they change the tests will fail. If that is unsatisfactory, I'm happy to set these tests up using a temporary directory.

Quantisan commented 10 years ago

if you add the line with the trailing slash to show it doesn't matter then that would satisfy the issue. I can merge it in with that change.

sritchie commented 9 years ago

@Quantisan figured I'd just merge this. The more tests the better.