nathanmarz / cascalog

Data processing on Hadoop without the hassle.
Other
1.38k stars 178 forks source link

Normalize compression keywords for more-taps/hfs-delimited #268

Closed alexrobbins closed 9 years ago

alexrobbins commented 9 years ago

Current situation: hfs-textline accepts :compression as a keyword arg, with values :enable, :disable and :default. hfs-delimited accepts :compress? as a keyword arg, with anything truthy becoming TextLine$Compress/ENABLE

This seems broken. This patch adjusts (hfs/lfs)-delimited to accept the :compression argument with the same semantics as hfs-textline. It also retains the old behavior for backwards compatibility. Documentation is updated to match new usage.

sritchie commented 9 years ago

Nice, thanks!