search

nathanmarz / storm-contrib

A collection of spouts, bolts, serializers, DSLs, and other goodies to use with Storm
Eclipse Public License 1.0
580 stars 340 forks source link

Updated storm-kafka to support Kafka 0.8 #42

Closed jasondana closed 10 years ago

jasondana commented 10 years ago

Updates have been verified to work with Kafka 0.8 and Storm 0.9.0.1

alexlovelltroy commented 10 years ago

This looks really useful. What can I do to help move this forward?

chris-downs commented 10 years ago

+1

vsagar commented 10 years ago

+1

gurkanoluc commented 10 years ago

+1

dschiavu commented 10 years ago

Nice, but, what's the point in having two Kafka spout implementations? This fork https://github.com/wurstmeister/storm-kafka-0.8-plus/ has been working fine for a long time.

jasondana commented 10 years ago

The objective wasn't to provide a second implementation. In all honesty, I wasn't aware of that fork's existence. Adding support for 0.8 was fairly trivial and I felt it would be convenient for others to be able to acquire it from storm-contrib.

jasondana commented 10 years ago

It appears Storm-Kafka 0.8 Plus provides an almost identical implementation but with better Kafka feature support and is more actively maintained. Closing in favor of this fork.

https://github.com/wurstmeister/storm-kafka-0.8-plus/

dschiavu commented 10 years ago

I read a post by a Storm developer (@ptgoetz?) on the mailing list stating that storm-kafka-0.8-plus is the Kafka spout implementation that will be included in future official Apache Storm releases, so my reasoning is that it's better to focus on that implementation. But thanks anyway!