search

nathanmarz / storm-deploy

One click deploy for Storm clusters on AWS
Other
516 stars 148 forks source link

Document how storm-deploy works with release tags #46

Open lorcan opened 10 years ago

lorcan commented 10 years ago

The documentation covered in #45 suggests that to work with release 0.9.0-rc2 you run the following:

lein deploy-storm --start --name mycluster --branch master --commit 32098d5b2694434ea43d430a4703fbe51bab268f

However there is a more natural way:

lein deploy-storm --start --name mycluster --commit 0.9.0-rc2

The storm-deploy method signatures and variable names contained in #45 constantly refer to SHA1s Given that storm-deploy safely takes tags as well as commit SHA1s I would like to update the source code to reflect that. I'll submit a pull-request if there is any buy-in. This would be a non-functional change.