nathanpeck / s3-upload-stream

A Node.js module for streaming data to Amazon S3 via the multipart upload API
MIT License
347 stars 46 forks source link

A way to provide tests #1

Closed boutell closed 10 years ago

boutell commented 11 years ago

Hey, thanks for writing this, it looks super useful and I plan to try it to address some issues with backing up files I don't have space to make a giant tarball out of on disk before sending them to S3.

Re: the problem of distributing tests, I solved this in another module that employs S3. I just require that certain environment variables be set, and read those from process.env.

Another way is to require a .gitignored file at the start of your tests, and provide a .example version of that file to show folks how to present their credentials correctly. Since it is .gitignored your credentials never wind up in the repo.

Cheers!

nathanpeck commented 10 years ago

Thanks for the suggestion.

nathanpeck commented 10 years ago

@boutell I just wanted to let you know that I have added tests now using a stubbed out S3 API. Closing this issue now.