nathanpeck / s3-upload-stream

A Node.js module for streaming data to Amazon S3 via the multipart upload API
MIT License
347 stars 46 forks source link

New version of aws-sdk has a validation for Number, doesn't accept String anymore #2

Closed marekhrabe closed 10 years ago

marekhrabe commented 10 years ago

This was an error I was getting:

Error: Expected params.PartNumber to be a number
at fail (/Users/marekhrabe/dev/generator/plugins/piffle-exporter/node_modules/aws-sdk/lib/param_validator.js:125:26)
at validateType (/Users/marekhrabe/dev/generator/plugins/piffle-exporter/node_modules/aws-sdk/lib/param_validator.js:152:10)
at validateScalar (/Users/marekhrabe/dev/generator/plugins/piffle-exporter/node_modules/aws-sdk/lib/param_validator.js:111:21)
at validateMember (/Users/marekhrabe/dev/generator/plugins/piffle-exporter/node_modules/aws-sdk/lib/param_validator.js:75:21)
at validateStructure (/Users/marekhrabe/dev/generator/plugins/piffle-exporter/node_modules/aws-sdk/lib/param_validator.js:55:14)
at validate (/Users/marekhrabe/dev/generator/plugins/piffle-exporter/node_modules/aws-sdk/lib/param_validator.js:30:17)
at Request.VALIDATE_PARAMETERS (/Users/marekhrabe/dev/generator/plugins/piffle-exporter/node_modules/aws-sdk/lib/event_listeners.js:111:32)
at Request.callListeners (/Users/marekhrabe/dev/generator/plugins/piffle-exporter/node_modules/aws-sdk/lib/sequential_executor.js:132:20)
at Request.<anonymous> (/Users/marekhrabe/dev/generator/plugins/piffle-exporter/node_modules/aws-sdk/lib/sequential_executor.js:123:18)
at /Users/marekhrabe/dev/generator/plugins/piffle-exporter/node_modules/aws-sdk/lib/event_listeners.js:98:9
nathanpeck commented 10 years ago

Thanks a lot!

nnnnathann commented 10 years ago

Hi guys, thanks for sharing this module, and for fixing this bug. Any chance we could get an npm publish after the fix?

nathanpeck commented 10 years ago

I just published an updated version with the fix.

nnnnathann commented 10 years ago

Thanks a lot!

marekhrabe commented 10 years ago

Thanks too, Merry Christmas :)