search

nathanpeck / s3-upload-stream

A Node.js module for streaming data to Amazon S3 via the multipart upload API
MIT License
347 stars 46 forks source link

Default maxPartSize is 1,000,000 bytes bigger than minimum #22

Closed konklone closed 10 years ago

konklone commented 10 years ago

It looks like a typo:

    var partSizeThreshold = 6242880;

    // Set the maximum amount of data that we will keep in memory before flushing it to S3 as a part
    // of the multipart upload
    ws.maxPartSize = function (partSize) {
      if (partSize < 5242880)
        partSize = 5242880;

      partSizeThreshold = partSize;
      return ws;
    };

If it's intentional, maybe a comment saying why?

nathanpeck commented 10 years ago

Definitely a typo. I'll correct it.

nathanpeck commented 10 years ago

Fixed in 1.0.4