nathanregner / platformio2nix

1 stars 1 forks source link

`ln` fails in configurePhase on libraries that have spaces in the name #3

Closed crabdancing closed 3 days ago

crabdancing commented 4 days ago

I haven't looked at the Nix code in depth, but I have a pretty good guess why this happens :P

ln thinking FOC is the target indicates path generated with Nix expression is not wrapped in quotes. See error context:

warning: Git tree '/home/ada/Projects/esc-test' is dirty
error: builder for '/nix/store/950rr3mm8h7ixxpv4y3hr46qimps6s1y-my-project.drv' failed with exit code 1;
       last 7 log lines:
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/h6rhvnz00vnahwvdvsp08aj8v26xaags-jqp6z9kazvvwwiqrfv3jgzppq6vnvsvn-source
       > source root is jqp6z9kazvvwwiqrfv3jgzppq6vnvsvn-source
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > ln: target 'FOC': No such file or directory
       For full logs, run 'nix log /nix/store/950rr3mm8h7ixxpv4y3hr46qimps6s1y-my-project.drv'.
crabdancing commented 4 days ago

PR opened here.

crabdancing commented 4 days ago

Side note: after applying the fix, I get a subsequent error about 'failing to produce an output path' -- but it does succeed when evaluating against the marlin example flake, so is likely an unrelated error. I'm not really sure what's happening, there. Should probably open a separate issue about it.

error: builder for '/nix/store/597yajk8rxn04kdb8clv4vm476p07xhz-my-project.drv' failed to produce output path for out
put 'out' at '/nix/store/597yajk8rxn04kdb8clv4vm476p07xhz-my-project.drv.chroot/root/nix/store/riavm0jyhpl1vvmnqsf6dn
qirhi09yzm-my-project'

Edit: I believe I needed manually written buildPhase. As it stands, it's a more or less empty derivation output.

crabdancing commented 3 days ago

Closed via PR merge.