Attributes aren't responsive for hover Popover effect

nathanreyes / v-calendar

An elegant calendar and datepicker plugin for Vue.

https://vcalendar.io

MIT License

4.32k stars 840 forks source link

Attributes aren't responsive for hover Popover effect #1441

Open TylerWanta opened 4 months ago

TylerWanta commented 4 months ago

If you use the default hover trigger for showing the popovers, the attributes won't be responsive.

Steps to reproduce:

Create Calendar with attributes and with hover trigger for Popover.
Add a new attribute to a day with an attribute.
hover over day

You'll see that the day doesn't include the new attribute.

Seems like the custom Popover directive for CalendarDay isn't being called. Not sure why though

TylerWanta commented 4 months ago

I managed to fix it by just watching the dayPopover object in CalendarDay.vue and manually remove and re add handlers. I forked the repo and created a new package on npm with a fix. v-calendar-tw if anyone is curious or see the pull request if you just want to copy it yourself https://github.com/nathanreyes/v-calendar/commit/351664645c43bb603eefe0698a0046f519a14c1c