nathansamson / ws281x-rpi

MIT License
4 stars 1 forks source link

MIT License NOTICE #1

Open JMurph2015 opened 1 year ago

JMurph2015 commented 1 year ago

Hello!

I was just taking perusing the Rust LED ecosystem recently and noticed your project mentioned it was inspired by my rpi-ws281x/rpi-ws281x-rust (rs_ws281x). Then I read through your README and notice it included some of my original language from that project's README, and the I saw your build.rs is an exact copy of mine down to my comments, etc. etc. The MIT license is indeed permissive, but it does have one important requirement if you are copying/modifying the work that you carry a copyright acknowledgement (usually in the form of a NOTICE file) carrying my original copyright message( "Copyright 2018, Joseph Murphy"); and a copy of the MIT license.

Sorry if this comes off like me being a prick, but I just appreciate having my work properly credited at least when it's used. Thank you!

nathansamson commented 1 year ago

I've never wanted to not credit your work!

I've mentioned you in the README from the beginning

Inspired on the rust bindings of the rpi ws281x driver.

But I understand you feel this might not be enough (and you are right according to the copyright, something I missed!), so I've added you to the LICENSE file. I hope this satisfies the copyright message. If you feel it is still not done correctly let me know.

Note: I might actually archive this repo anyway. This code was written at a time when I was experimenting with smart-leds and checking out possibilities to do things on arduino/raspberry pi's/ESP32. I think for my use case I would go with ESP32 so I would not really have any intrest in keeping this code up to date.