search

nathansamuell / groundStation

AIAA Ground station Repo
MIT License
0 stars 0 forks source link

Image Doesn't Display globally #3

Open nathansamuell opened 5 months ago

nathansamuell commented 5 months ago

NOTE: This issue does NOT apply to the main branch at present. It will after the packaging branch is merged into main after it is linted

Currently, the only way the image on the login screen is loaded correctly is if the python3 -m groundStation call is done from inside the package code in a specific directory where the path makes sense. Ideally, this image should display regardless of where the command is called from on the filesystem

nathansamuell commented 5 months ago

For Ben - how to contribute

run these commands: git clone the repository git branch issue2 git checkout issue2 git push origin issue 2

the first command brings the code down to you. The second command creates a branch for you to work on your changes, and then the third command puts you on that branch instead of the main branch.

IMPORTANT-- Now, instead of running git push after you commit, make sure you specify the issue2 branch. don't push to the main branch. you can do this by issuing "git push origin issue2" -- This will create the branch on the repo on github and allow you to use it just like the normal main branch. when you're done, you can submit a pull request for the branch, and I'll merge it into the main code if it passes all the tests.

nathansamuell commented 5 months ago

fixed by adding init.py which somehow imports the package as a directory in commit F216983

nathansamuell commented 5 months ago

didn't fix it that was a fluke