search

nathansearles / slidesjs

SlidesJS is obsolete and no longer maintained.
https://nathansearles.github.io/slidesjs/
1.72k stars 357 forks source link

Slide disappears/height problem with bootstrap/hide (possible fix included) #566

Open foxx opened 10 years ago

foxx commented 10 years ago

When using hidden-* in bootstrap to show/hide an element containing a slideshow, the slide does not re-appear again.

This is due to;

      height = (this.options.height / this.options.width) * width;
      this.options.height = height;

The only fix I could find so far was to add;

      height = (this.options.height / this.options.width) * width;

      if (!height) {
        return;
      }

Please let me know if this approach is accepted, if so I will send a PR.

Thanks