search

nathansmith / formalize

Teach your forms some manners!
http://formalize.me
1.31k stars 120 forks source link

Update jquery.formalize.min.js: missing semicolon #70

Closed alexef closed 10 years ago

alexef commented 10 years ago

Add a missing semicolon which breaks our bundle script package.

nathansmith commented 10 years ago

Out of curiosity, what minifier would you recommend?

I'm using UglifyJS, so there's no guarantee that a future minified version won't also be missing the semi-colon at the end.

Which makes me wonder: Why are you not just using your bundle tool to minify the full version of formalize.js instead?

It seems like it'd make more sense to work with un-minified files, and minify/concatenate them all at once for deployment to production.

Anyway, that's just my 2 cents.

:)

alexef commented 10 years ago

You are right, I haven't thought it through; it is indeed better to work with the un-minified version.

Thanks for the merge anyway, cheers!