nathansmith / unsemantic

Fluid grid for mobile, tablet, and desktop.
http://unsemantic.com
MIT License
1.38k stars 162 forks source link

[enhancement] Add missing bower.json. #48

Closed timgluz closed 10 years ago

timgluz commented 10 years ago

Hey, maintainer(s) of nathansmith/unsemantic!

We at VersionEye are working hard to keep up the quality of the bower's registry.

We just finished our initial analysis of the quality of the Bower.io registry:

7530 - registered packages, 224 of them doesnt exists anymore;

We analysed 7306 existing packages and 1070 of them don't have bower.json on the master branch ( that's where a Bower client pulls a data ).

Sadly, your library nathansmith/unsemantic is one of them.

Can you spare 15 minutes to help us to make Bower better?

Just add a new file bower.json and change attributes.

{
  "name": "nathansmith/unsemantic",
  "version": "1.0.0",
  "main": "path/to/main.css",
  "description": "please add it",
  "license": "Eclipse",
  "ignore": [
    ".jshintrc",
    "**/*.txt"
  ],
  "dependencies": {
    "<dependency_name>": "<semantic_version>",
    "<dependency_name>": "<Local_folder>",
    "<dependency_name>": "<package>"
  },
  "devDependencies": {
    "<test-framework-name>": "<version>"
  }
}

Read more about bower.json on the official spefication and nodejs semver library has great examples of proper versioning.

NB! Please validate your bower.json with jsonlint before commiting your updates.

Thank you!

Timo, twitter: @versioneye email: timo@versioneye.com VersionEye - no more legacy software!

shwoodard commented 10 years ago

+1

nathansmith commented 10 years ago

I'm not opposed to the idea.

I was putting this off because I was still retooling some of Unsemantic's internals (should be "done" now).

I'm a little fuzzy on what I'd need to list as dependencies.

Would those be external repositories? If Unsemantic itself is self-contained, do I need to list anything there?

jasonhuck commented 10 years ago

I don't think you'd need to list any dependencies unless, for example, you wanted a bower install to also grab normalize.css, which is also available via bower, separately and automatically.

nathansmith commented 10 years ago

So, I think this is right…

https://github.com/nathansmith/unsemantic/commit/339f706562659bc65712fc838b79b1079c4ed4ad

Let me know if you encounter any problems.

freefri commented 10 years ago

I've just updated bower components successfully getting your version cf9031874c I'm getting your Bower.json file and everything looks fine. Thx