search

nathansmith / unsemantic

Fluid grid for mobile, tablet, and desktop.
http://unsemantic.com
MIT License
1.38k stars 162 forks source link

Created lib for projects that depend on pre-transpiled modules. #96

Closed coreyleelarson closed 6 years ago

coreyleelarson commented 6 years ago

My project is bundled using webpack, where we exclude: /node_modules/ in the babel-loader config. As a result, any packages under our node_modules directory that are not pre-transpiled error out during build.

As most packages I've seen are pre-transpiled prior to publishing, I thought unsemantic could benefit from doing this.

nathansmith commented 6 years ago

Ah, good call. The ES6 project for which I'm using Unsemantic now, it has an internally mirrored (subset) of NPM. As I'm forced to just use my files directly, I hadn't run into this yet.

I get what you mean, that this needn't be a step for the public NPM. I'll merge this, and will then tag it as 1.2.1.

nathansmith commented 6 years ago

Okay, done.

https://github.com/nathansmith/unsemantic/tree/1.2.1

I changed "lib" to "assets/react/dist" just to kind of tuck it away, for people who are only using the CSS/Sass, as to not clutter up the root.

Also, the "assets/react/readme.md" file can now apply to both…

  1. "assets/react/dist"
  2. "assets/react/source"
coreyleelarson commented 6 years ago

Gotcha, love it!