Witness::GoalTest is incorrect - Githubissues

nathansttt / hog2

Pathfinding and search testbed/visualization suite. Current code is in PDB-refactor branch.

MIT License

112 stars 55 forks source link

Witness::GoalTest is incorrect #93

Open Samarium150 opened 4 weeks ago

Samarium150 commented 4 weeks ago

@arc-s14 Witness::GoalTest method contains bugs

11e64fc6b5328f0a9e1859faf2a9376a9f146033:

puzzle

daff8ca87e470a96865bb4c5bb8ef9d9f8bf78b2:

puzzle

Some obvious ones:

If node.path is empty, then calling node.path.back() will cause undefined behaviour (memory access out of bound). https://github.com/nathansttt/hog2/blob/e470a47abf8de036b8b55b312a62c493f7156f02/environments/Witness.h#L2859-L2861
Variables should be initialized. https://github.com/nathansttt/hog2/blob/e470a47abf8de036b8b55b312a62c493f7156f02/environments/Witness.h#L2908-L2909