search

nathantannar4 / Transmission

Bridges UIKit presentation APIs to a SwiftUI API so you can use presentation controllers, interactive transitions and more.
BSD 2-Clause "Simplified" License
419 stars 15 forks source link

Transmission 1.0.1 causing Fastlane CI issues #17

Closed danqing closed 11 months ago

danqing commented 11 months ago

Hi Nathan!

I think GitHub actions / Xcode 15 is buggy in general so this may not be something fixable here, but I only get the error when updating Transmission from 0.1.27 to 1.0.1 (and only on Github CI, with macOS 13 image):

[02:03:15]: ▸ ** ARCHIVE FAILED **
[02:03:15]: ▸ The following build commands failed:
[02:03:15]: ▸   ComputeTargetDependencyGraph
[02:03:15]: ▸ (1 failure)

Specifically, doing so changes the following dependencies (I was reverting it so red is what's added when upgrading and green is what's removed):

CleanShot 2023-11-25 at 21 10 04@2x

Anything that you can spot / recommend me trying? Thank you!

nathantannar4 commented 11 months ago

hmm, odd cannot reproduce locally. Are you able to move to 1.0.0 for each?

danqing commented 11 months ago

1.0.0 also doesn't work. Only 0.x works. (Maybe the issue is swift-syntax? Where is that used?)

nathantannar4 commented 11 months ago

It's used in Engine for Swift Macro support. I'll try to setup a github action to reproduce

nathantannar4 commented 11 months ago

Ok, this seems to be caused by Engine adding Swift Macro support. As part of the build, you must "allow" macros to be enabled when they come from a Swift Package.

Looks like the solution now is to add the -skipMacroValidation flag to xcodebuild.

Swift Macro rollout hasn't been the best, add this to the developer pain points

danqing commented 11 months ago

That worked! Thank you Nathan!