nathantannar4 / Transmission

Bridges UIKit presentation APIs to a SwiftUI API so you can use presentation controllers, interactive transitions and more.
BSD 2-Clause "Simplified" License
378 stars 13 forks source link

destinationCoordinator stopped working after updating to 1.1.2 #31

Closed PhilipDukhov closed 8 months ago

PhilipDukhov commented 8 months ago

In 1.1.0 below code works fine, but in 1.1.2 Dismiss button has no effect


struct ContentView: View {
    @State var presented = false

    var body: some View {
        NavigationView {
            Button("show") {
                presented = true
            }
            .destination(isPresented: $presented) {
                ViewToDismiss()
            }
        }
    }
}

struct ViewToDismiss: View {
    @Environment(\.destinationCoordinator) var destinationCoordinator

    var body: some View {
        Button("Dismiss") {
            destinationCoordinator.pop()
        }
    }
}
nathantannar4 commented 8 months ago

Attempting to fix #24 broke this, fixed in 1.1.3 but mutating the binding cannot dismiss with animation. DestinationCoordinator must be used.