nathantannar4 / Transmission

Bridges UIKit presentation APIs to a SwiftUI API so you can use presentation controllers, interactive transitions and more.
BSD 2-Clause "Simplified" License
378 stars 13 forks source link

Swipe back gesture not working with iOS 17.4 #37

Closed jacksonh closed 6 months ago

jacksonh commented 6 months ago

I can try and make a more minimal test case but figured I'd file an issue to start. After updating to iOS 17.4 our swipe back gesture stopped working when using PresentationLink:

    var slideTransition: PresentationLinkTransition {
      PresentationLinkTransition.slide(
        options: PresentationLinkTransition.SlideTransitionOptions(edge: .trailing,
                                                                   options:
                                                                    PresentationLinkTransition.Options(
                                                                      modalPresentationCapturesStatusBarAppearance: true
                                                                    )
                                                                  ))
    }

        PresentationLink(transition: slideTransition, isPresented: $viewModel.linkIsActive) {
          if let presentingItem = viewModel.selectedItem {
            if presentingItem.isPDF {
              PDFContainerView(item: presentingItem)
            } else {
              WebReaderContainerView(item: presentingItem)
            }
          } else {
            EmptyView()
          }
        } label: {
          EmptyView()
        }.buttonStyle(.plain)

our current deps:

      .package(url: "https://github.com/nathantannar4/Engine", exact: "1.5.1"),
    .package(url: "https://github.com/nathantannar4/Turbocharger", exact: "1.1.4"),
    .package(url: "https://github.com/nathantannar4/Transmission", from: "1.1.4")
jacksonh commented 6 months ago

I'll close this one as I think its something with WKWebView not Transmission.