nathantannar4 / Transmission

Bridges UIKit presentation APIs to a SwiftUI API so you can use presentation controllers, interactive transitions and more.
BSD 2-Clause "Simplified" License
378 stars 13 forks source link

Slide presentation drag gesture is broken with keyboard presented #52

Closed PhilipDukhov closed 1 month ago

PhilipDukhov commented 1 month ago
  1. While keyboard is presented, drag gesture doesn't work properly
  2. Root view(Color.gray) has keyboard padding which is not expected (let me know if I should create a separate issue)

RocketSim_Recording_iPhone_15_Pro_Max_6 7_2024-07-18_4 43 31 PM

struct Issue52: View {
    var body: some View {
        VStack {
            Color.gray.frame(height: 400)
        }
        .presentation(
            transition: .slide(options: .init(options: .init(preferredPresentationBackgroundColor: .clear))),
            isPresented: .constant(true)
        ) {
            TextField("2", text: .constant("1"))
                .frame(maxHeight: .infinity)
                .background(Material.thinMaterial)
        }
    }
}
nathantannar4 commented 1 month ago

Fixed in 1.4.1 👍🏻

PhilipDukhov commented 1 month ago

It seems like fixed on Simulator, but on real device I still encourage issues:

https://github.com/user-attachments/assets/d6c3a509-9fe9-4308-bdd6-7f6c09c6fc7c

vpontis commented 1 month ago

@nathantannar4 could we re-open this issue to track this? Or should we make another issue for it? Let us know if there's anything we can do to make this easier to repro or fix.

nathantannar4 commented 1 month ago

Fixed in 1.4.3!

vpontis commented 1 month ago

Ah this seems to be working great, thank you @nathantannar4!