search

nathantannar4 / Transmission

Bridges UIKit presentation APIs to a SwiftUI API so you can use presentation controllers, interactive transitions and more.
BSD 2-Clause "Simplified" License
378 stars 13 forks source link

Sheet presentation with `.ideal` detent crashes #8

Closed vpontis closed 8 months ago

vpontis commented 11 months ago

We've seen crashes with partial sheets w/ the ideal detent. It's not reliably reproducible and the logs aren't good.

I thought to open this issue in case it is useful and if I find more data / crash logs / ideas, I'll add them here :)

CleanShot 2023-10-04 at 17 36 53@2x

nathantannar4 commented 11 months ago

I did make some improvements in 0.1.25 that could have helped with this. Been trying to reproduce this but no luck yet. Do you know which iOS version this is crashing on?

vpontis commented 11 months ago

We are on 0.1.26 — I think it is happening less but that's totally anecdotal.

Re iOS version — I've seen it on iOS 17 and iOS 17 beta. I haven't been testing 16 as much.

I think I caught it in simulator + XCode yesterday. I'm 90% sure it's the same issue, here are screenshots of the debugger:

CleanShot 2023-10-04 at 19 26 44@2x CleanShot 2023-10-04 at 19 26 42@2x CleanShot 2023-10-04 at 19 26 40@2x

nathantannar4 commented 9 months ago

@vpontis curious if you have still seen this on 0.1.27 or higher?

vpontis commented 9 months ago

@vpontis curious if you have still seen this on 0.1.27 or higher?

Anecdotally it's been better! I'll dig into some of the crashes this week.

nathantannar4 commented 8 months ago

Closing for now, but let me know if you see the issue again

vpontis commented 8 months ago

It's either much better or totally solved now.