Regex makers moved to their own functions

nathanvda / cocoon

Dynamic nested forms using jQuery made easy; works with formtastic, simple_form or default forms

http://github.com/nathanvda/cocoon

MIT License

3.08k stars 385 forks source link

Regex makers moved to their own functions #539

Closed Mirv closed 5 years ago

Mirv commented 5 years ago

Really minor tweak here moving some functionality to a spot where it can be utilized in a slightly more DRY fashion, but mostly because it's helping me reason about the Jquery code for another change.

Used verb style function names & hooked them in at the assignment spot of the variables they were already going.

Cleared out some extra white space near bottom.

Mirv commented 5 years ago

I don't know why the tests fails since it's only moving them to another function within the file and calling the same technique as the others.

Mirv commented 5 years ago

Not quite happy with this change even though it works locally on each server - found implementation that's better.