Panel is hidden when used inside DTGE

[bjarnef]

At the moment there is a port of DTGE (Doc Type Grid Editor) to Umbraco v8: https://github.com/umco/umbraco-doc-type-grid-editor/pull/137

It seems when Nested Contently is used as datatype on a Doc Type, then is the panel collapsed/hidden.

Without Nested Contently datatype.

With Nested Contently datatype.

I guess it is an issue with one of these, where it set display:none: https://github.com/nathanwoulfe/NestingContently/blob/01625ef7aad01136dfe29825fc1188c562763053/src/NestingContently/backoffice/editor.controller.js#L12

https://github.com/nathanwoulfe/NestingContently/blob/01625ef7aad01136dfe29825fc1188c562763053/src/NestingContently/backoffice/button.component.js#L51

You can try the v8 port of DTGE, e.g. til install the zip file via backoffice installer. https://ci.appveyor.com/project/UMCO/umbraco-doc-type-grid-editor/build/artifacts

[nathanwoulfe]

Yup, will be due to how I'm hiding the editor - I haven't ever looked at this in DTGE.

I should probably be using a selector rather than grabbing the parent element, but will probably be better off waiting for the port to finish in case things change...

[bjarnef]

@nathanwoulfe this shouldn't change unless Umbraco change this in core, because DTGE is using the umb-tabbed-content component to render these panels (tabs/groups) and their properties. https://github.com/umco/umbraco-doc-type-grid-editor/blob/9a13c1ae301a90eaf18592fe94797effc334c774/src/Our.Umbraco.DocTypeGridEditor/Web/UI/App_Plugins/DocTypeGridEditor/Views/doctypegrideditor.dialog.html#L92-L94

[bjarnef]

Maybe it should check if the parent element has the class umb-nested-content-property-container instead?

[bjarnef]

Untested, but something like this might work:

const propElm = findAncestor($element[0], 'umb-property');

if (propElm) {
    var parentElem = propElm.parentElement;
    if (parentElem.classList.contains('umb-nested-content-property-container')) {
        parentElem.style.display = 'none';
    }
} 

[bjarnef]

I also noticed this console error.

wheree it seems to break here:

I just added Nested Content to a document type where DTGE and The Grid wasn't used. With an empty Nested Content and adding a new item, I get this console error (tested on Umbraco v8.1.0)

[nathanwoulfe]

Hi @bjarnef, pretty sure that error is coming from an old version of the directive - latest V8 compatible release has no reference to node.tabs since that no longer exists (it's all node.variant[n].tabs.

Was this a fresh install or update of an old site? Possibly an incorrect version installed?

[bjarnef]

@nathanwoulfe ahh I was still using the original version 1.0.6, fixed after installing v2.0.1

And this console error elementClass is not defined seems to be fixes here: https://github.com/nathanwoulfe/NestingContently/pull/10

[nathanwoulfe]

Glad to hear it. Wouldn't be surprised tho if there are other issues on 8.1. Let me know if anything pops up.

[bjarnef]

@nathanwoulfe remember to update the Umbraco package as well. Not all might use the NuGet version :) https://our.umbraco.com/packages/backoffice-extensions/nesting-contently/ https://www.nuget.org/packages/NestingContently.Umbraco/

[nathanwoulfe]

@bjarnef done. Not going to lie, I always forget to update the package repo... Would be awesome to have that integrated with my build...