Fix for Umbraco v8.7.0 - Githubissues

nathanwoulfe / NestingContently

A property editor for disabling Nested Content items and Block elements in Umbraco

9 stars 8 forks source link

Fix for Umbraco v8.7.0 #23

Closed greystate closed 4 years ago

greystate commented 4 years ago

This fixes #22 by using the .findAncestor() function instead of directly going for the .parentElement.

A few questions though:

Would it make sense to skip the '.umb-element' ancestor and directly target the .umb-nested-content-property-container right away?
How do you feel about substituting the .closest() method for .findAncestor()? I noticed it's already being used in the button.component.js file.

nathanwoulfe commented 4 years ago

@greystate if it works, it works - I have no issue with changing that method. Wonder if this would have any impact on #20 (which I've kind of been ignoring...)

Thanks for the speedy PR too!

greystate commented 4 years ago

I've updated the PR with a condensed version that uses the closest() method and goes directly for the .umb-nested-content-property-container ancestor.

I've tried installing the built 2.1.2-alpha ZIP in a v8.7.0 where it worked "as usual".

Will try in a v8.6.4 as well just to double check that it still works there.

greystate commented 4 years ago

Tried installing in an Umbraco v8.6.4 too - works as usual.

nathanwoulfe commented 4 years ago

Awesome, thanks @greystate! I think I might have a look too at how this all works (or doesn't) with block list, then bundle it into a V3 release.