search

nathanwoulfe / NestingContently

A property editor for disabling Nested Content items and Block elements in Umbraco
9 stars 8 forks source link

Add Support For Configurable Property Name & Settings #47

Open Nicholas-Westby opened 9 months ago

Nicholas-Westby commented 9 months ago

It seems like "umbracoNaviHide" is hard coded: https://github.com/nathanwoulfe/NestingContently/blob/2adcf311240be893beb784a4191f0d3cdc4665e6/src/NestingContently.Umbraco/Backoffice/app/Backoffice/button.component.ts#L49

Our projects use "isVisible" and this is in the settings for the block list item rather than in the main set of properties for that item (i.e., the "Settings model" rather than the "Content model"):

is-visible

It would be handy if both of these possibilities were configurable (either via json config or startup code).

Nicholas-Westby commented 9 months ago

Come to think of it, I suppose the boolean behavior would also have to be inverted since this is an "is visible" rather than an "is hidden" situation.

Aside: we use an inverted bool for this (the bool data type with true/enabled/toggled as the default state).