search

nathanwoulfe / PieMan

Simple analytics for Umbraco
MIT License
11 stars 6 forks source link

Localization of text #4

Closed bjarnef closed 9 years ago

bjarnef commented 9 years ago

Since the package is located in the content section and is intended for editors is should have localized text, e.g. for "Show analytics for previous", "days" etc.

You could see how we have localized most of the text in the Analytics package https://github.com/warrenbuckley/Analytics

nathanwoulfe commented 9 years ago

Thanks Bjarne, will do.

MarcStoecker commented 9 years ago

Totally agree, would be awesome if you could allow localization.

nathanwoulfe commented 9 years ago

@bjarnef @esn303 - shouldn't be too difficult, looks like the Merchello team found a useful solution

MarcStoecker commented 9 years ago

Good news! Thanks for looking into it. :)

nathanwoulfe commented 9 years ago

Localization is in version 0.5.0. Only did Danish and English for starters, will work on adding more when I have time.

bjarnef commented 9 years ago

@nathanwoulfe something you may consider in https://github.com/nathanwoulfe/PieMan/blob/master/App_Plugins/Pieman/auth/OAuthCallback.aspx.cs is to use TextService instead of ui.Text which is deprecated: https://twitter.com/Shazwazza/status/613986522631667712 .. not sure if it handle fallback for older versions of Umbraco 7.

nathanwoulfe commented 9 years ago

I wanted to fix the deprecration warnings, and was digging in LocationService but couldn't find it. That would be why - it's in TextService.