Email comment should send comment of previous approver

williamOng commented 5 years ago

I'm not sure whether this should be a feature request or bug, but the emails sent always uses the original comment made by the person who initiates the workflow for the approval requests.

      case EmailType.ApprovalRequest:
                    body = string.Format(EmailApprovalRequestString,
                        useGenericName ? "Umbraco user" : _finalTask.UserGroup.Name, docUrl, docTitle, instance.AuthorComment,
                        instance.AuthorUser.Name, typeDescription, string.Empty);
                    break;

Should it be using _finalTask.Comment like in the ApprovalRejection case, instead of instance.AuthorComment ? I understand that the AuthorComment can give context for why the change is being made. Can we maybe add both the author comment and the previous comment? In which case it would be a feature request.

willchis commented 5 years ago

+1 from me. Also, possibly a different issue, but I'm not seeing any rejection emails at all (v 7.15.3, cloud). The approval requests and worflow-cancelled emails seem fine, but the rejection emails never appear. @williamOng are you able to receive rejection emails? Thanks.

williamOng commented 5 years ago

@willchis I do remember having rejection email issues. I think I saw one of the switch cases being wrong when I looked into it.

nathanwoulfe commented 5 years ago

@williamOng I've got a build running now which includes changes to add the full comment history for the current workflow process in each email. Grab the zip from the link below, and replace the dll in your project.

Let me know if this is working correctly, and I'll push out a release.

https://ci.appveyor.com/project/nathanwoulfe/umbracoworkflow/build/artifacts

nathanwoulfe commented 5 years ago

resolved in v1.1.11

nathanwoulfe / Plumber

Email comment should send comment of previous approver #109