Fix problem assessing the truthyness of the "boolean" prevalues

nathanwoulfe / tabulate

Manage large datasets in Umbraco, without losing your sanity

7 stars 3 forks source link

Fix problem assessing the truthyness of the "boolean" prevalues #18

Closed bowserm closed 1 year ago

bowserm commented 3 years ago

The problem we were experiencing is that the "Wide" and "Admin Only" prevalue settings were always coming back as true. Our sites were stuck in "Admin Only Settings" mode. I found that the adminOnly and wide "boolean" prevalues were coming back with values of "1" and "0". "0" is a truthy value. I adjusted the logic so that we are comparing them to true which works better.

bowserm commented 3 years ago

I have created a github issue for this PR. Hopefully that helps give a little context, but I've mostly repeated the same things I stated in the first comment of this PR.

Issue: https://github.com/nathanwoulfe/tabulate/issues/19

nathanwoulfe commented 3 years ago

Awesome, thanks @bowserm

I'll get onto this soon as I can.